Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify 'content' in connector descriptions #12481

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Specify 'content' in connector descriptions #12481

wants to merge 4 commits into from
+35 −27

Conversation

seanstory
Copy link
Member

@seanstory seanstory commented Jan 27, 2025 •
edited
Loading

Proposed commit message

Adds a 'content sync' qualifier to the descriptions of Connector integrations, to align with 8.x descriptions that had been hardcoded in Kibana.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@seanstory seanstory added the enhancement New feature or request label Jan 27, 2025
@seanstory seanstory marked this pull request as ready for review January 27, 2025 15:40
@seanstory seanstory requested review from a team as code owners January 27, 2025 15:40
@elasticmachine
Copy link

elasticmachine commented Jan 27, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkroh andrewkroh added Integration:elastic_connectors Elastic Connectors Team:Search-Extract and Transform Search - Extract and Transform [elastic/search-extract-and-transform] bugfix Pull request that fixes a bug issue and removed enhancement New feature or request labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix Pull request that fixes a bug issue Integration:elastic_connectors Elastic Connectors Team:Search-Extract and Transform Search - Extract and Transform [elastic/search-extract-and-transform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanstory @elasticmachine @jsoriano @andrewkroh